PLATY-62: Updated reportAProblem to reattach form validation after a successful submission #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…successful submission
|
thanks @JoPintoPaul. can you add an entry to the Unreleased section of the |
|
@rpowis Changelog updated. |
rpowis
changed the title
|
@JoPintoPaul almost 😄 just missing the url to the PR. i've added it for you. i also took the liberty of updating the PR description 👍 |
rpowis
approved these changes
Nov 21, 2017
hmrc-web-operations
pushed a commit
that referenced
this pull request
Nov 22, 2017
generated from commit 59457b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the reportAProblem form validation passes client-side but fails on the server, the result of the ajax call is another form which replaces the existing one. The submit event handler isn't attached to the replacement form though so when it's submitted, it redirects without the CSRF token.
Solution
Call the function to attach the submit event handler after a successful ajax request in case it's a form.